Alon Bar-Lev has posted comments on this change.
Change subject: storage: set block schedule elevator using udev
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/12-vdsm-elevator.rules
Line 8: #
Line 9:
Line 10: # Udev rules for elevator setting.
Line 11:
Line 12: ACTION=="add|change", SUBSYSTEM=="block", ENV{DEVTYPE}=="disk",
RUN+="vdsm-elevator.sh deadline"
1. I don't like shell being executed in udev, too many thing can go wrong.
2. there are no other rules this way.
3. It harder to reuse... for example, user may want to revert:
ACTION=="add|change", SUBSYSTEM=="block", ENV{DEVTYPE}=="disk",
KERNEL='sda',RUN+="vdsm-elevator.sh cfq"
Why do you need to filter dm devices? This will just add more complexity.
Thanks.
--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
