Alon Bar-Lev has posted comments on this change.

Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................


Patch Set 3: (4 inline comments)

....................................................
File tests/getAllVolumesTests.py
Line 61: 
Line 62:             Input file name: 'glob_<sdName>.out
Line 63:             Input file format: str(glob.glob(<imgsDir>))
Line 64:             When
Line 65:             <imgsDir> = @vdsmlibdir@/data-center/mnt/<mntPoint>/
It is a *COMMENT*, reader should do the subst in mind.
Line 66:                             <sdName>/images/*.meta
Line 67:             """
Line 68:             sdPath, globExp = volMetaPattern.split('/images')
Line 69:             sdHead, sdName = os.path.split(sdPath)


....................................................
File vdsm.spec.in
Line 459:     /usr/sbin/setsebool sanlock_use_nfs on
Line 460: fi
Line 461: 
Line 462: %post
Line 463: # upgrade old locations
Please suggest.
Line 464: if [ -d /rhev/data-center -a -z "$(ls 
%{_localstatedir}/lib/vdsm/data-center/hsm-tasks)" ]; then
Line 465:     mv /rhev/data-center %{_localstatedir}/lib/vdsm/data-center.new 
&& \
Line 466:         rm -rf %{_localstatedir}/lib/vdsm/data-center &&
Line 467:         mv %{_localstatedir}/lib/vdsm/data-center.new 
%{_localstatedir}/lib/vdsm/data-center &&


....................................................
File vdsm/storage/fileSD.py
Line 63: 
Line 64: 
Line 65: def getDomUuidFromMetafilePath(metafile):
Line 66:     # Metafile path has pattern:
Line 67:     #  @vdsmlibdir@/data-center/mnt/export-path/sdUUID/dom_md/metadata
It is a *COMMENT*, reader should do the subst in mind.
Line 68: 
Line 69:     metaList = os.path.normpath(metafile).split('/')
Line 70:     return metaList[-3]
Line 71: 


....................................................
File vdsm/storage/fileVolume.py
Line 39: 
Line 40: 
Line 41: def getDomUuidFromVolumePath(volPath):
Line 42:     # Volume path has pattern:
Line 43:     #  @vdsmlibdir@/data-center/spUUID/sdUUID/images/imgUUID/volUUID
It is a *COMMENT*, reader should do the subst in mind.
Line 44: 
Line 45:     # sdUUID position after data-center
Line 46:     sdUUIDPos = 3
Line 47: 


--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to