Ryan Harper has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/getAllVolumesTests.py
Line 61:
Line 62: Input file name: 'glob_<sdName>.out
Line 63: Input file format: str(glob.glob(<imgsDir>))
Line 64: When
Line 65: <imgsDir> = @vdsmlibdir@/data-center/mnt/<mntPoint>/
I think we have to fetch this via vdsm.config. AFAIK, only files with the .in
suffix get sed to apply the @FOO@ replacement.
Line 66: <sdName>/images/*.meta
Line 67: """
Line 68: sdPath, globExp = volMetaPattern.split('/images')
Line 69: sdHead, sdName = os.path.split(sdPath)
....................................................
File vdsm.spec.in
Line 463: %post
Line 464: # upgrade old locations
Line 465: if [ -d /rhev/data-center -a -z "$(ls %{vdsmrepodir}/hsm-tasks)" ];
then
Line 466: mv /rhev/data-center %{vdsmrepodir}/data-center.new && \
Line 467: rm -rf %{vdsmrepodir} &&
Looks like you just wiped out %{vdsmrepodir}/data-center.new which was the data
from /rhev/data-center ...
Is that what we're doing here? I'm assuming by upgrade, you mean to retain any
existing data?
Line 468: mv %{vdsmrepodir}.new %{vdsmrepodir} &&
Line 469: ( rmdir /rhev || : )
Line 470: fi
Line 471:
--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
