Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................
Patch Set 4: (1 inline comment)
Could you also update the comment in vdsm/storage/sp.py line 452
(v4.10.1-87-g8fd1e69 here according to git describe):
# Cleanup links to domains under /rhev/datacenter/poolName
....................................................
File vdsm.spec.in
Line 465: if [ -d /rhev/data-center -a -z "$(ls %{vdsmrepodir}/hsm-tasks)" ];
then
Line 466: mv /rhev/data-center %{vdsmrepodir}/data-center.new && \
Line 467: rm -rf %{vdsmrepodir} &&
Line 468: mv %{vdsmrepodir}.new %{vdsmrepodir} &&
Line 469: rm -rf /rhev
Assuming there is nothing the user put there, an rmdir should be just as
effective. If it's not empty, it must be user data. Personally I rather leave
some (user) trash behind than remove some user data.
Line 470: fi
Line 471:
Line 472: # set the vdsm "secret" password for libvirt
Line 473: %{_bindir}/vdsm-tool set-saslpasswd
--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
