Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 465: if [ -d /rhev/data-center -a -z "$(ls %{vdsmrepodir}/hsm-tasks)" ]; 
then
Line 466:     mv /rhev/data-center %{vdsmrepodir}/data-center.new && \
Line 467:         rm -rf %{vdsmrepodir} &&
Line 468:         mv %{vdsmrepodir}.new %{vdsmrepodir} &&
Line 469:         rmdir /rhev
I think --ignore-fail-on-non-empty is an important parameter here to suppress 
the error in case it is non-empty.
Line 470: fi
Line 471: 
Line 472: # set the vdsm "secret" password for libvirt
Line 473: %{_bindir}/vdsm-tool set-saslpasswd


--
To view, visit http://gerrit.ovirt.org/8500
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ed316fedbf2e4d7e5bf741b7c77a39704994ae7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to