Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/52354/4/lib/vdsm/certutils.py File lib/vdsm/certutils.py: Line 23: Line 24: def get_cert_paths(path): Line 25: return (os.path.join(path, 'keys', 'vdsmkey.pem'), Line 26: os.path.join(path, 'certs', 'vdsmcert.pem'), Line 27: os.path.join(path, 'certs', 'cacert.pem')) > We don't need new module to have 3 constant strings, just more this to vdsm Done https://gerrit.ovirt.org/#/c/52354/4/lib/vdsm/tool/configurators/certificates.py File lib/vdsm/tool/configurators/certificates.py: Line 30 Line 31 Line 32 Line 33 Line 34 > These constants are just fine, not sure why do you want to replace them. All of them are the same in few places in vdsm. I just want to have the definition common and be used in many places. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
