Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 7: (2 comments) (very partial review) https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 157: # localtion of the certificates Line 158: def get_cert_paths(path): Line 159: return (os.path.join(path, 'keys', 'vdsmkey.pem'), Line 160: os.path.join(path, 'certs', 'vdsmcert.pem'), Line 161: os.path.join(path, 'certs', 'cacert.pem')) > We need it. I don't understand your answe, Piotr. https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 103 Line 104 Line 105 Line 106 Line 107 > Additionally, ovirt-imageio-daemon is using the /etc/pki/vdsm/ - we cannot this library is for the client side. A client may want to connect to various clusters, each with a different certificate. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
