Nir Soffer has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 263: Line 264: def create_ssl_context(): Line 265: sslctx = None Line 266: if config.getboolean('vars', 'ssl'): Line 267: path = config.get('vars', 'trust_store_path') > As you can see here we are using it. Do you suggest to hard code this value It is already hard coded in certificates.py and in libvirt.py (via import). Can you explain how this path will work with the hard coded values? Line 268: protocol = ( Line 269: ssl.PROTOCOL_SSLv23 Line 270: if config.get('vars', 'ssl_protocol') == 'sslv23' Line 271: else ssl.PROTOCOL_TLSv1 https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 103 Line 104 Line 105 Line 106 Line 107 > In this code we need it. We would need to explore whether we could hard cod We are already hard coding this value in tool.certificates.PKI_DIR, so this means that the current code does not support dynamic pki dir. Your patch is not a refactoring but adding features that we don't need. I don't want to maintain features that nobody asked for. When we find broken feature that is not needed we remove it. If you think this feature is needed and the fact that it does not work is a bug, open a bug. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
