Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 157: # localtion of the certificates Line 158: def get_cert_paths(path): Line 159: return (os.path.join(path, 'keys', 'vdsmkey.pem'), Line 160: os.path.join(path, 'certs', 'vdsmcert.pem'), Line 161: os.path.join(path, 'certs', 'cacert.pem')) > I don't understand your answe, Piotr. Sorry for not being clear. Will make them constant https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 103 Line 104 Line 105 Line 106 Line 107 > this library is for the client side. A client may want to connect to variou Correct, I will revert this change. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
