Nir Soffer has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/59306/12/Makefile.am File Makefile.am: Line 111: exit 1; \ Line 112: fi \ Line 113: else \ Line 114: echo "Error: please install tox $(TOX_MIN_VERSION) or later.";\ Line 115: exit 1; \ > Done - but actually why not adding a new target named 'style check' and hav Because we want to make it easy to run pep8 or pyflakes. To run both of them you can simply run: make pep8 pyflakes I think it is easy enough so we don't need style-check target. Line 116: fi Line 117: Line 118: .PHONY: python3 Line 119: python3: all -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
