Irit Goihman has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/59306/15/Makefile.am
File Makefile.am:

Line 83:        done;
Line 84: 
Line 85: .PHONY: pyflakes
Line 86: pyflakes: tox
Line 87:        tox -- pyflakes ;
> ; not needed now
Done
Line 88: 
Line 89: .PHONY: pep8
Line 90: pep8: tox
Line 91:        tox -- pep8 ;


Line 87:        tox -- pyflakes ;
Line 88: 
Line 89: .PHONY: pep8
Line 90: pep8: tox
Line 91:        tox -- pep8 ;
> ; not needed now
Done
Line 92: 
Line 93: .PHONY: tox
Line 94: tox:
Line 95:        if [ `command -v tox` >/dev/null 2>&1 ]; then \


-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to