Irit Goihman has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/59306/16/build-aux/vercmp File build-aux/vercmp: Line 28: if args.verbose: Line 29: logging.basicConfig(level=logging.DEBUG, format="%(name)s: %(message)s") Line 30: retval = compare_versions(args.actual_version, args.required_version) Line 31: sys.exit(retval) Line 32: > 2 empty lines need here to make pep8 tool happy. You also need to add this Done Line 33: def compare_versions(actual_version, required_version): Line 34: actual_version = [int(n) for n in actual_version.split('.')] Line 35: required_version = [int(n) for n in required_version.split('.')] Line 36: -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
