Nir Soffer has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/59306/13/build-aux/vercmp File build-aux/vercmp: Line 38: logging.debug("{} == {}".format(actual_version, required_version)) Line 39: sys.exit(1) Line 40: else: Line 41: logging.debug("{} > {}".format(actual_version, required_version)) Line 42: sys.exit(2) > you're right but I need to return the value to shell script and the two pos We can return a value here, and exit with this value in main. Line 43: Line 44: Line 45: def parse_args(): Line 46: parser = argparse.ArgumentParser(description='compare actual version to ' -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
