Mark Wu has posted comments on this change.
Change subject: AdvancedStatsThread: Rotate duplicated stats log
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 57: MBPS_TO_BPS = 10 ** 6 / 8
Line 58:
Line 59: def __init__(self, vm):
Line 60: log = vm.getVMLogger(utils.AdvancedStatsThread.DEFAULT_LOG)
Line 61: utils.AdvancedStatsThread.__init__(self, log=log, daemon=True)
how about passing vmId instead of log to AdvancedStatsThread and let
AdvancedStatsThread construct its logging.
Line 62: self._vm = vm
Line 63:
Line 64: self.highWrite = (
Line 65: utils.AdvancedStatsFunction(
....................................................
File vdsm/logger.conf.in
Line 38:
Line 39: [logger_Stats]
Line 40: level=DEBUG
Line 41: handlers=rotatefile
Line 42: qualname=Stats
Is VmStats better?
Line 43: propagate=0
Line 44:
Line 45: [handler_syslog]
Line 46: level=WARNING
Line 66: args: []
Line 67: formatter: none
Line 68:
Line 69: [handler_rotatefile]
Line 70: class=logging.handlers.RotatingFileHandler
vdsm uses system service logrotate to rotate its log files, so you needn't use
python's RotatingFileHandler. Take a look at vdsm-logrotate.conf.in. You
could add a separate entry for vm stats logs if needed.
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
Line 72: filters=storage.misc.TracebackRepeatFilter
Line 73: level=DEBUG
Line 74: formatter=long
Line 68:
Line 69: [handler_rotatefile]
Line 70: class=logging.handlers.RotatingFileHandler
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
Line 72: filters=storage.misc.TracebackRepeatFilter
implement a new filter to filter out the large amount of duplicate message?
Line 73: level=DEBUG
Line 74: formatter=long
Line 75:
Line 76: [formatter_simple]
--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
