Zhou Zheng Sheng has posted comments on this change.

Change subject: AdvancedStatsThread: Rotate duplicated stats log
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/logger.conf.in
Line 68: 
Line 69: [handler_rotatefile]
Line 70: class=logging.handlers.RotatingFileHandler
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
Line 72: filters=storage.misc.TracebackRepeatFilter
Thanks Yaniv. This patch is for throwing the stats log into a dedicated file 
and get it rotated when it's large. So "Disk %s stats not available" will go to 
that file as well after the patch is applied.

Next I will submit another patch to cut down the noise from the duplicated log.
Line 73: level=DEBUG
Line 74: formatter=long
Line 75: 
Line 76: [formatter_simple]


--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to