Yaniv Bronhaim has posted comments on this change.
Change subject: AdvancedStatsThread: Rotate duplicated stats log
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/logger.conf.in
Line 68:
Line 69: [handler_rotatefile]
Line 70: class=logging.handlers.RotatingFileHandler
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
Line 72: filters=storage.misc.TracebackRepeatFilter
First, TracebackRepeatFilter is not in misc.storage so you should fix it -its
under logUtils.py (also in handler_logfile), and second I would add tests for
this TracebackRepeatFilter if you came up with working in the area, I'm not
sure about the implementation of this RepeatFilter.
And again, this filter filters only traceback log during raise of exceptions,
and i thought you want to avoid repetition of the same log record... or I miss
the point.
Line 73: level=DEBUG
Line 74: formatter=long
Line 75:
Line 76: [formatter_simple]
--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
