Yaniv Bronhaim has posted comments on this change.
Change subject: AdvancedStatsThread: Rotate duplicated stats log
......................................................................
Patch Set 3: (2 inline comments)
I agree with Mark, only exceptions during stat collection should be reported
also to vdsm.log.
And if an error is repeated more then 'SOME_CONSTANT' times you can report it
once to vdsm.log as well
....................................................
File vdsm/logger.conf.in
Line 67: formatter: none
Line 68:
Line 69: [handler_statslog]
Line 70: class=logging.handlers.RotatingFileHandler
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
can you explain the meaning of those args by comment or make constants for them
?
Line 72: filters=logUtils.TracebackRepeatFilter
Line 73: level=DEBUG
Line 74: formatter=long
Line 75:
....................................................
File vdsm/vm.py
Line 363: CONTROLLER_DEVICES: [], GENERAL_DEVICES: [],
Line 364: BALLOON_DEVICES: [], REDIR_DEVICES: []}
Line 365:
Line 366: def wrapLogger(self, log):
Line 367: return SimpleLogAdapter(log, {"vmId": self.conf['vmId']})
why do you need this wrapper? What is bad with the regular assignment: self.log
= SImpleLogAdaptaer(...) ?
Line 368:
Line 369: def _get_lastStatus(self):
Line 370: PAUSED_STATES = ('Powering down', 'RebootInProgress', 'Up')
Line 371: if not self._guestCpuRunning and self._lastStatus in
PAUSED_STATES:
--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
