Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG Commit Message: Line 4: Commit: Piotr Kliczewski <piotr.kliczew...@gmail.com> Line 5: CommitDate: 2016-07-05 16:08:19 +0200 Line 6: Line 7: utils: build cert paths in single place Line 8: > Please describe the behavior change - we don't use the trusted store config Done Line 9: Line 10: Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs File build-aux/Makefile.subs: Line 28 Line 29 Line 30 Line 31 Line 32 > We probably need to remove vdsmtsdir (and TRUSTEDSTORE?) from configure.ac Will remove https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt' Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@' Line 156: Line 157: # location of the certificates Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki/vdsm') > Use: Done Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem') Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem') https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 28: from vdsm.tool.configfile import ConfigFile, ParserWrapper Line 29: from vdsm.tool.validate_ovirt_certs import validate_ovirt_certs Line 30: from vdsm import utils Line 31: from vdsm import constants Line 32: > Unrelated Done Line 33: Line 34: if utils.isOvirtNode(): Line 35: from ovirt.node.utils.fs import Config as NodeCfg Line 36: -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
