Nir Soffer has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64301/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4769 Line 4770 Line 4771 Line 4772 Line 4773 > Actually, _syncVolumeChain is defined on the VM and the drive isn't held as Right, but this operation should have been defined in the cleanup thread. A method should use the same abstraction level (e.g operations on self, or operations on self.vm etc.) -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
