Nir Soffer has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4782: self.vm.enableDriveMonitor() Line 4783: self.success = True Line 4784: self.vm.log.info("Synchronization completed (job %s)", Line 4785: self.job['jobID']) Line 4786: self.teardown_top_volume() > After another thought, I think it is better not to fail merge in this case, I don't think this is a good idea, if we cannot deactivate the lv, or remove the symlinks in /run/vdsm, the system is fucked up and we should fail hard and loud. If you do not agree you should add a big comment here explaining why the clean must succeed when we cannot teardown the volume. Line 4787: Line 4788: def isSuccessful(self): Line 4789: """ Line 4790: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
