Nir Soffer has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/64301/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4764: self.drive.imageID, baseVolUUID, Line 4765: topVolInfo['capacity']) Line 4766: Line 4767: def teardown_top_volume(self): Line 4768: # TODO move this method to storage public API > This needs to happen before we can merge. We can't have code like this in The plan is to backport this to 4.0, where it is ok to add these dependencies. Nobody is going to break vdsm to multiple processes in 4.0 :-) In master I expect to see a patch adding a proper storage api soon. Line 4769: sd_manifest = sdc.sdCache.produce_manifest(self.drive.domainID) Line 4770: sd_manifest.teardownVolume(self.drive.imageID, Line 4771: self.job['topVolume']) Line 4772: Line 4787: # not part of the chain. Now, we want to teardown the top volume. Note Line 4788: # that if volume deactivation fails, we don't want to fail the megre Line 4789: # whole operation as the VM is running without issues. It is worth to Line 4790: # note that if volume deactivation fails, chances are high that the Line 4791: # environment is severely damaged. I do want to the operation to fail, we cannot continue to use this environment. Line 4792: self.teardown_top_volume() Line 4793: Line 4794: def isSuccessful(self): Line 4795: """ -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
