Ala Hino has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge ......................................................................
Patch Set 5: (5 comments) https://gerrit.ovirt.org/#/c/64301/5/vdsm/storage/sd.py File vdsm/storage/sd.py: PS5, Line 531: teared > torn Done PS5, Line 532: teared > torn Done https://gerrit.ovirt.org/#/c/64301/5/vdsm/virt/vm.py File vdsm/virt/vm.py: PS5, Line 4786: nvolume > volume Done PS5, Line 4788: megre > merge Done Line 4787: # not part of the chain. Now, we want to teardown the top volume. Note Line 4788: # that if volume deactivation fails, we don't want to fail the megre Line 4789: # whole operation as the VM is running without issues. It is worth to Line 4790: # note that if volume deactivation fails, chances are high that the Line 4791: # environment is severely damaged. > I do want to the operation to fail, we cannot continue to use this environm Moved Line 4792: self.teardown_top_volume() Line 4793: Line 4794: def isSuccessful(self): Line 4795: """ -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
