Zhou Zheng Sheng has posted comments on this change. Change subject: AdvancedStatsThread: Rotate duplicated stats log ......................................................................
Patch Set 4: Thanks Peter. System logrotate can not rotate the log very often. Typical usage of logrotate will perform the work several times during the day. RotatingFileHandler can rotate the log instantly. When the storage domain goes down, the stats log will be very noisy, as reported in the bugzilla, the size grows very rapidly. We can not wait for logrotate to do the work, so I think RotatingFileHandler is good for this usage. For your concern, I am considering adding a comment in the .conf file or in the commit message to explain my choice. -- To view, visit http://gerrit.ovirt.org/8884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
