Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Catch OSError in _translateConnectionError ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 2314: return se.iSCSIifaceError.code, se.iSCSIifaceError.message Line 2315: if isinstance(e, iscsi.iscsiadm.IscsiError): Line 2316: return se.iSCSISetupError.code, se.iSCSISetupError.message Line 2317: if isinstance(e, os.OSError, os.OSError.message): Line 2318: return os.OSError.code, os.OSError.message I do not think that os.OSError.code exists, and suspect that you'd want to translate the exception to a StorageException, legible by Engine. Line 2319: Line 2320: if hasattr(e, 'code'): Line 2321: return e.code, e.message Line 2322: -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
