Ayal Baron has posted comments on this change. Change subject: vdsm: Catch OSError in _translateConnectionError ......................................................................
Patch Set 3: wrt removing _translateConnectionError it should be discussed u/s first as I'm not sure Saggi would agree with that, but in general I dislike it as well. however, that should be dealt with separately (i.e. out of the scope of this fix). Dan, the OSError is *generated* by mount.py "raise OSError(errno.ENOENT, 'Mount target %s not found' % target)" so there is no real lower level to catch it. mount.py is built in this way (dealing with OS level errors only). This can be debated, but again not relevant to this patch (a bigger rehaul perhaps). -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
