Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Catch OSError in _translateConnectionError ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) I'd appreciate a response to my former question: "Where is the problematic call to getRecord()? MountConnection.connect? I'd rather catch OSError there, and translate it to whatever is needed." .................................................... File vdsm/storage/hsm.py Line 2352: return 0, "" Line 2353: Line 2354: if isinstance(e, mount.MountError): Line 2355: return se.MountError.code, se.MountError.message Line 2356: if isinstance(e, OSError): _translateConnectionError() is called in 6 different places. I find it hard to believe that in all of these cases, any type of OSError means StorageServerValidationError. Line 2357: return (se.StorageServerValidationError.code, Line 2358: se.StorageServerValidationError.message) Line 2359: if isinstance(e, iscsi.iscsiadm.IscsiAuthenticationError): Line 2360: return se.iSCSILoginAuthError.code, se.iSCSILoginAuthError.message -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
