Eduardo has posted comments on this change. Change subject: vdsm: Catch OSError in _translateConnectionError ......................................................................
Patch Set 3: As stated in: https://bugzilla.redhat.com/show_bug.cgi?id=883877#c10 mount.py is raising OSError when fails it fails to find the dst directory that just succeed to remove, after a failed mount. The mount error is catched and swallowed and verify is called immediately. Applying something in the spirit of: http://gerrit.ovirt.org/#/c/12042/ makes mount.py raise the correct MountError for errors during mount, making this change redundant. If OSErrors occurs in mount, there is nothing much to do in higher levels of vdsm. It may be due to mount point being created/deleted by other thread or another _strange Thing_ that is probably a programming error. I thing that is worth to distinguish between the failed mount that is something for the user to fix (permissions, existence of the mount, etc.) and errors during the manipulation of the mount point. -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
