Eduardo has posted comments on this change.
Change subject: image: do not delete the template on deleteImage
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/sd.py
Line 144: storage_repository = config.get('irs', 'repository')
Line 145: mountBasePath = os.path.join(storage_repository, DOMAIN_MNT_POINT)
Line 146:
Line 147:
Line 148: def getVolsOfImage(allVols, imgUUID, withTemplate=True):
A function should do only one thing.
If this filter is repeated so many times (this is not the case now) a wrapper
function should be added.
The "template" concept is very limiting and I prefer to avoid including this in
interfaces, including the internal ones.
Line 149: """ Filter allVols dict for volumes related to imgUUID.
Line 150:
Line 151: Returns {volName: (([templateImge], imgUUID, [otherImg]), volPar)
Line 152: For a template volume will be more than one image entry.
--
To view, visit http://gerrit.ovirt.org/12105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
