Federico Simoncelli has posted comments on this change. Change subject: image: do not delete the template on deleteImage ......................................................................
Patch Set 2: (2 inline comments) .................................................... File tests/getAllVolumesTests.py Line 119: imgs=[IMAGE_UUID], Line 120: parent='145a8e80-09fa-4aef-a686-c9dd0dbd2af6'), Line 121: } Line 122: Line 123: imgVolumes = dict(templateVolumes.items() + imageVolumes.items()) This might be confusing imgVolumes/imageVolumes. To be renamed eventually. Line 124: Line 125: # These volumes are added to check that additional unrelated Line 126: # volumes are not included in the results. Line 127: unrelatedVolumes = { .................................................... File vdsm/storage/sd.py Line 144: storage_repository = config.get('irs', 'repository') Line 145: mountBasePath = os.path.join(storage_repository, DOMAIN_MNT_POINT) Line 146: Line 147: Line 148: def getVolsOfImage(allVols, imgUUID, withTemplate=True): Dan, we can consider to use includeTemplate if you think it's more clear. Line 149: """ Line 150: Filter allVols dict for volumes related to imgUUID. The optional Line 151: withTemplate parameter is used to specify if the volume of the Line 152: template should be returned too (if any). -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches