Federico Simoncelli has posted comments on this change. Change subject: image: do not delete the template on deleteImage ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/sd.py Line 154: allVols: The getAllVols() return dict. Line 155: """ Line 156: Line 157: return dict((volName, vol) for volName, vol in allVols.iteritems() Line 158: if (vol.imgs[0] == imgUUID or Yes vol1 is there twice as I was enumerating the volumes by image. (vol1, [img1, img2]) is not a template regardless of the image used to address it, it's a template for img2 but for any other operation (eg: copy/move) is a regular image and it has its own official (img1) uuid. It's not the semantic that is complicated, withTemplate has the same semantic of a coffee with or without the sugar (tea for you :-). It's how the image structure (and how it is represented) that is complicated. Line 159: (withTemplate and imgUUID in vol.imgs))) Line 160: Line 161: Line 162: def supportsUnicode(version): -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
