Dan Kenigsberg has posted comments on this change. Change subject: image: do not delete the template on deleteImage ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/sd.py Line 154: allVols: The getAllVols() return dict. Line 155: """ Line 156: Line 157: return dict((volName, vol) for volName, vol in allVols.iteritems() Line 158: if (vol.imgs[0] == imgUUID or Do you intentionally have vol1 twice in the chain? Isn't (vol1, [img1, img2]) a template regardless of the specified img? The semantics of ithTemplate=True is a bit confusing. Line 159: (withTemplate and imgUUID in vol.imgs))) Line 160: Line 161: Line 162: def supportsUnicode(version): -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
