Dan Kenigsberg has posted comments on this change. Change subject: build: closer to open source versioning and release cycle ......................................................................
Patch Set 1: (4 inline comments) .................................................... Commit Message Line 48: - 4.11.0-0.0.master Line 49: - 4.11.0-0.1.alpha Line 50: - 4.11.0-0.2.master Line 51: - 4.11.0-0.3.beta Line 52: - 4.11.0-0.4.master why do you expect the "beta" suffix to be lost in favor of "master"? (I saw an explanation to Federico, but did not understand it) Line 53: - 4.11.0-0.5.rc Line 54: - 4.11.0-0.6.master Line 55: - 4.11.0-1 Line 56: - 4.12.0-0.0.master .................................................... File configure.ac Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: # Autoconf initialization Line 22: define([PRODUCT_VERSION], [4.11.0]) Yes, I hate to have the same information duplicated: once in this macro, and a second time - in the git tag. However, I understand that the current state, where a build performed a minute before a release has the same version as the months-old former release, is wrong. I tried to think of something less manual, which could have a sane guess about the next version, but failed. Thus, I see no choice but to accept something like this, where the first commit post a release is to advance the hard-coded prospected next version. Line 23: define([PRODUCT_VERSION_SUFFIX], [_master]) Line 24: AC_INIT([vdsm], PRODUCT_VERSION[]PRODUCT_VERSION_SUFFIX, [[email protected]]) Line 25: AC_CONFIG_AUX_DIR([build-aux]) Line 26: Line 26: Line 27: m4_include([m4/ax_python_module.m4]) Line 28: Line 29: # RPM version Line 30: PACKAGE_RPM_VERSION="PRODUCT_VERSION" Why do we need this PACKAGE_RPM_VERSION macro? It should never differ from PRODUCT_VERSION. Line 31: PACKAGE_RPM_RELEASE="0.0.$(echo PRODUCT_VERSION_SUFFIX | sed 's/^_//')" Line 32: AC_SUBST([PACKAGE_RPM_VERSION]) Line 33: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 34: .................................................... File Makefile.am Line 84: Line 85: srpm: dist Line 86: SUFFIX=".`date -u +%Y%m%d%H%M%S`"; \ Line 87: if [ -d "$(top_srcdir)/.git" ]; then \ Line 88: SUFFIX="$$SUFFIX.git`GIT_DIR="$(top_srcdir)/.git" $(GIT) rev-parse --short=16 HEAD`"; \ how about counting git commits since latest tag, as git-describe does? these so-long rpm release names make me dizzy. Line 89: fi; \ Line 90: rpmbuild \ Line 91: -ts \ Line 92: --define="release_suffix $$SUFFIX" \ -- To view, visit http://gerrit.ovirt.org/12448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a73089d47804ca31e3a4d80aaf811fa011ba1f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
