Federico Simoncelli has posted comments on this change. Change subject: build: closer to open source versioning and release cycle ......................................................................
Patch Set 1: (2 inline comments) .................................................... Commit Message Line 62: - PACKAGE_RPM_RELEASE - rpm release Line 63: Line 64: Unlike current versioning implementation we disconnect the versioning Line 65: from the git branch information, as the git branch information is aware Line 66: of /past/ versions, while a branch is work toward the /next/ version. Let's separate the logic from the technology. What you're describing is not limited to committing a new PRODUCT_VERSION/SUFFIX in configure.ac, it can be accomplished with tags too. For example we could think of a tagging flow as: - v4.11.0 - v4.12.0-rc1 - v4.12.0-rc2 - v4.12.0-rc3 - ... - v4.12.0 All the commits between the rc are identified by the number of patches that have been commited (as per git describe), eg: - vdsm-4.12.0-rc1 (rc1 no additional patches) - vdsm-4.12.0-rc1.2 (rc1, 2 additional patches) - vdsm-4.12.0-rc2 (rc2 no additional patches) - ... Line 67: Line 68: A valid sequence for release cycle: Line 69: PRODUCT_VERSION=4.11.0 Line 70: PRODUCT_VERSION_SUFFIX=_master .................................................... File configure.ac Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: # Autoconf initialization Line 22: define([PRODUCT_VERSION], [4.11.0]) Dan well you could just start tagging with rc when you feel that we're moving to the next milestone. As I proposed on the commit message: - v4.11.0 - v4.12.0-rc1 - v4.12.0-rc2 - ... - v4.12.0 We'd just need pkg-version to handle the rc suffix. Line 23: define([PRODUCT_VERSION_SUFFIX], [_master]) Line 24: AC_INIT([vdsm], PRODUCT_VERSION[]PRODUCT_VERSION_SUFFIX, [[email protected]]) Line 25: AC_CONFIG_AUX_DIR([build-aux]) Line 26: -- To view, visit http://gerrit.ovirt.org/12448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a73089d47804ca31e3a4d80aaf811fa011ba1f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
