Alon Bar-Lev has posted comments on this change. Change subject: build: closer to open source versioning and release cycle ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 62: - PACKAGE_RPM_RELEASE - rpm release Line 63: Line 64: Unlike current versioning implementation we disconnect the versioning Line 65: from the git branch information, as the git branch information is aware Line 66: of /past/ versions, while a branch is work toward the /next/ version. This is non standard approach, I can discuss this if we are not re-inventing the wheel (yet again). vdsm-4.12-0-rc1.2 is usually a re-release of rc1, or build#2. All these efforts only because we have are lazy to commit explicit version... I don't see the benefit of this. Line 67: Line 68: A valid sequence for release cycle: Line 69: PRODUCT_VERSION=4.11.0 Line 70: PRODUCT_VERSION_SUFFIX=_master -- To view, visit http://gerrit.ovirt.org/12448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a73089d47804ca31e3a4d80aaf811fa011ba1f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
