Alon Bar-Lev has posted comments on this change. Change subject: build: closer to open source versioning and release cycle ......................................................................
Patch Set 1: (2 inline comments) .................................................... File configure.ac Line 26: Line 27: m4_include([m4/ax_python_module.m4]) Line 28: Line 29: # RPM version Line 30: PACKAGE_RPM_VERSION="PRODUCT_VERSION" There are m4 macros and shell variable.... PRODUCT_VERSION is the m4 macro you manage to effect the configure behavior, it must be m4 macro as it is fed into the AC_INIT. I could have used: AC_SUBST([PACKAGE_RPM_VERSION], PRODUCT_VERSION) But then there was a difference between PACKAGE_RPM_VERSION and PACKAGE_RPM_RELEASE in the syntax... so I prefer to move into the shell namespace and have consistent sequence. Line 31: PACKAGE_RPM_RELEASE="0.0.$(echo PRODUCT_VERSION_SUFFIX | sed 's/^_//')" Line 32: AC_SUBST([PACKAGE_RPM_VERSION]) Line 33: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 34: .................................................... File Makefile.am Line 84: Line 85: srpm: dist Line 86: SUFFIX=".`date -u +%Y%m%d%H%M%S`"; \ Line 87: if [ -d "$(top_srcdir)/.git" ]; then \ Line 88: SUFFIX="$$SUFFIX.git`GIT_DIR="$(top_srcdir)/.git" $(GIT) rev-parse --short=16 HEAD`"; \ I would like to avoid git magic, branching and such. The problem was the revision length, so we can use shorter... It is only meant to have some eye catcher to find this in rpm git log. Line 89: fi; \ Line 90: rpmbuild \ Line 91: -ts \ Line 92: --define="release_suffix $$SUFFIX" \ -- To view, visit http://gerrit.ovirt.org/12448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a73089d47804ca31e3a4d80aaf811fa011ba1f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
