Saggi Mizrahi has posted comments on this change. Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info only if host SPM ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 310: raise se.IsSpm(spUUID) Line 311: Line 312: @classmethod Line 313: def getPool(cls, spUUID): Line 314: # If passed None, return first pool Edu is right, bypass the call for your case and get it straight from the dict so that you don't change all other users Line 315: if spUUID is None: Line 316: try: Line 317: return cls.pools.popitem() Line 318: except KeyError: -- To view, visit http://gerrit.ovirt.org/12517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
