Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info
only if host SPM
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2048: # getSharedLock(tasksResource...)
Line 2049: if 'spm_tasks' in options:
Line 2050: if spUUID is None:
Line 2051: raise se.ResourceException("Can't get SPM Tasks",
spUUID)
Line 2052: self.validateSPM(spUUID)
That's the only way without changing the interface of the methods. Engine will
have to pass also the uuid if I don't change the getPool method or use the
pools dict directly.
I'm not sure about the exception, if you prefer another exception please
suggest..
Line 2053: allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Line 2054: return dict(allTasksStatus=allTasksStatus)
Line 2055:
Line 2056: @public
--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
