Ayal Baron has posted comments on this change. Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info only if host SPM ......................................................................
Patch Set 8: Adding 1 variable in 'options' and 1 variable externally but mandating passing them both is ridiculous. Edu and Saggi's conceptual mistake is in thinking that the request is for spm tasks and not pool tasks as I've explained in the previous comment. The fact that you must be spm to get the pool tasks is an implementation detail. I'm fine with spUUID being a parameter within options if Saggi thinks this way we can deprecate it more easily later on, but having both options and an external parameter which are both mandatory and the value of the first is always the same (true) when the second is passed or not pass anything is just meaningless, ugly and doesn't make anything simpler (you still end up with a parameter, but now your API is even less legible). -- To view, visit http://gerrit.ovirt.org/12517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
