Yaniv Bronhaim has posted comments on this change. Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info only if host SPM ......................................................................
Patch Set 8: (1 inline comment) In patchset 5 I proposed a patch that uses only spUUID. Saggi and Edu told me that I can't do that because it doesn't refer to the command if I don't pass the 'spm_tasks' option, and Edu's comment was unclear, so after talking with saggi he convinced me that both 'spm_tasks' option and spUUID together are necessary to get the SPM tasks and get exception if not spm, otherwise it just has weird meaning (getAllTaskList with uuid..). If you prefer only spUUID as I proposed in the past, please add it to the BZ. .................................................... File vdsm/API.py Line 1362: Line 1363: def getDevicesVisibility(self, guidList): Line 1364: return self._irs.getDevicesVisibility(guidList) Line 1365: Line 1366: def getAllTasksInfo(self, options=None, spUUID=None): So reverting to patchset 5? does Edu agree with that? Line 1367: return self._irs.getAllTasksInfo(options, spUUID) Line 1368: Line 1369: def getAllTasksStatuses(self, options=None, spUUID=None): Line 1370: return self._irs.getAllTasksStatuses(options, spUUID) -- To view, visit http://gerrit.ovirt.org/12517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
