Ayal Baron has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host SPM ......................................................................
Patch Set 9: (7 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-02-27 17:37:57 +0200 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2013-03-12 18:16:55 +0200 Line 6: Line 7: getAllTasksList\Status with spUUID retrieves info only if host SPM s/SPM/is the SPM/ Line 8: Line 9: Request for tasks status or list with the option argument spUUID returns Line 10: if host is set to SPM. Without spUUID param vdsm returns its internal cache Line 11: info about the tasks, whether if runs as SPM or not. Line 5: CommitDate: 2013-03-12 18:16:55 +0200 Line 6: Line 7: getAllTasksList\Status with spUUID retrieves info only if host SPM Line 8: Line 9: Request for tasks status or list with the option argument spUUID returns s/status/statuses/ s/option/optional/ s/returns/will return only/ Line 10: if host is set to SPM. Without spUUID param vdsm returns its internal cache Line 11: info about the tasks, whether if runs as SPM or not. Line 12: Line 13: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=880547 Line 6: Line 7: getAllTasksList\Status with spUUID retrieves info only if host SPM Line 8: Line 9: Request for tasks status or list with the option argument spUUID returns Line 10: if host is set to SPM. Without spUUID param vdsm returns its internal cache s/set to/the/ s/returns/will return/ s/internal.*/all tasks it can find/ Line 11: info about the tasks, whether if runs as SPM or not. Line 12: Line 13: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=880547 Line 14: Signed-off-by: Yaniv Bronhaim <[email protected]> .................................................... File vdsm_api/vdsmapi-schema.json Line 337: # @Host.getAllTasksInfo: Line 338: # Line 339: # Get extra information about all tasks. Line 340: # Line 341: # @spUUID: #optional when asking for spmTasks, uuid of pool must passed same as before: s/when asking.*/when specified .../ Line 342: # Line 343: # Returns: Line 344: # A mapping of Task information Line 345: # .................................................... File vdsm/storage/hsm.py Line 2039: def getAllTasksStatuses(self, spUUID=None): Line 2040: """ Line 2041: Gets the status of all public tasks. Line 2042: Line 2043: :param spUUID: when asking spm tasks, pool uuid mast passed s/.*/if specified returns pool specific tasks otherwise will return all currently visible tasks/ Line 2044: Line 2045: :returns: a dict of all the tasks information. Line 2046: """ Line 2047: # getSharedLock(tasksResource...) Line 2044: Line 2045: :returns: a dict of all the tasks information. Line 2046: """ Line 2047: # getSharedLock(tasksResource...) Line 2048: if spUUID: Need to comment that currently pool tasks can only be retrieved by SPM Line 2049: self.validateSPM(spUUID) Line 2050: allTasksStatus = self.taskMng.getAllTasksStatuses("spm") Line 2051: return dict(allTasksStatus=allTasksStatus) Line 2052: Line 2082: :rtype: dict Line 2083: """ Line 2084: # getSharedLock(tasksResource...) Line 2085: # TODO: if spUUID passed, make sure tasks are relevant only to pool Line 2086: if spUUID: same Line 2087: self.validateSPM(spUUID) Line 2088: allTasksInfo = self.taskMng.getAllTasksInfo("spm") Line 2089: return dict(allTasksInfo=allTasksInfo) Line 2090: -- To view, visit http://gerrit.ovirt.org/12517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
