Eduardo has posted comments on this change. Change subject: vdsm: propagate MountError when mount fails ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/storageServer.py Line 213: exc_info=True) Line 214: try: Line 215: os.rmdir(self._getLocalPath()) Line 216: except OSError: Line 217: pass You should log here. Failing to remove the mount point points to a severe programming issue and may be the cause that failed the mount. Please remove the comment. Line 218: #We raise the MountError here since this is the real issue and not Line 219: #the minor rmdir success. Line 220: raise e Line 221: -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
