Eduardo has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File vdsm/storage/storageServer.py
Line 213: exc_info=True)
Line 214: try:
Line 215: os.rmdir(self._getLocalPath())
Line 216: except OSError:
Line 217: pass
If the directory was already removed at this point you have a raise.
Line 218: #We raise the MountError here since this is the real
issue and not
Line 219: #the minor rmdir success.
Line 220: raise e
Line 221:
Line 218: #We raise the MountError here since this is the real
issue and not
Line 219: #the minor rmdir success.
Line 220: raise e
Line 221:
Line 222: try:
You should not validate if the mount failed. If another clause, which not
raises, is added to the try mount you have the same bug that you are correcting
now. Else avoids this issue.
Line 223:
fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file)
Line 224: except se.StorageServerAccessPermissionError:
Line 225: try:
Line 226: self.disconnect()
Line 226: self.disconnect()
Line 227: except OSError:
Line 228: self.log.warn("Error while disconnecting after access
problem",
Line 229: exc_info=True)
Line 230: raise
raises OSError instead StorageServerAccessPermissionError
Line 231:
Line 232: def isConnected(self):
Line 233: return self._mount.isMounted()
Line 234:
--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
