Vered Volansky has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File vdsm/storage/storageServer.py
Line 200: if self._mount.isMounted():
Line 201: return
Line 202:
Line 203: try:
Line 204: os.makedirs(self._getLocalPath())
Is this really in the scope of this patch?
Line 205: except OSError as e:
Line 206: if e.errno != errno.EEXIST:
Line 207: raise
Line 208:
Line 213: exc_info=True)
Line 214: try:
Line 215: os.rmdir(self._getLocalPath())
Line 216: except OSError:
Line 217: pass
Will add log.
Line 218: #We raise the MountError here since this is the real
issue and not
Line 219: #the minor rmdir success.
Line 220: raise e
Line 221:
Line 226: self.disconnect()
Line 227: except OSError:
Line 228: self.log.warn("Error while disconnecting after access
problem",
Line 229: exc_info=True)
Line 230: raise
I believe this is beyond the scope of this patch as it attempts to fix a
specific bug. I don't object to submitting another one after this one. Ayal?
Line 231:
Line 232: def isConnected(self):
Line 233: return self._mount.isMounted()
Line 234:
--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
