Eduardo has posted comments on this change. Change subject: vdsm: propagate MountError when mount fails ......................................................................
Patch Set 6: (2 inline comments) .................................................... File vdsm/storage/storageServer.py Line 200: if self._mount.isMounted(): Line 201: return Line 202: Line 203: try: Line 204: os.makedirs(self._getLocalPath()) Please replace by fileutils.createdir() Line 205: except OSError as e: Line 206: if e.errno != errno.EEXIST: Line 207: raise Line 208: Line 218: #We raise the MountError here since this is the real issue and not Line 219: #the minor rmdir success. Line 220: raise e Line 221: Line 222: try: An else block will avoid future errors. Line 223: fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file) Line 224: except se.StorageServerAccessPermissionError: Line 225: try: Line 226: self.disconnect() -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
