Antoni Segura Puimedon has posted comments on this change.
Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_hooks/quantumvnic/before_vm_start.py
Line 11:
Line 12: QVNIC_PREFIX = 'quantumvnic_'
Line 13:
Line 14: # The maximum device name length in linux.
Line 15: DEV_MAX_LENGTH = 14
dev max length should be 15. for example:
sudo ip link add "0123456789abcde" type dummy
~/c/vdsm ❯❯❯ ip l
25: 0123456789abcde: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode
DEFAULT
link/ether ca:99:8b:dd:eb:66 brd ff:ff:ff:ff:ff:ff
but
~/c/vdsm ❯❯❯ sudo ip link add "0123456789abcdef" type dummy
Error: argument "0123456789abcdef" is wrong: "name" too long
So the limit is 15 and not 14.
Line 16:
Line 17: '''
Line 18: Openstack Quantum Hook
Line 19: ======================
Line 41: source.setAttribute('bridge', DUMMY_BRIDGE)
Line 42:
Line 43:
Line 44: def configureOvsVnic(domxml, iface, portId):
Line 45: INTEGRATION_BRIDGE = config.get('quantumvnic_hook',
'integration_bridge')
why the all caps?
Line 46: source = iface.getElementsByTagName('source')[0]
Line 47: source.setAttribute('bridge', INTEGRATION_BRIDGE)
Line 48:
Line 49: virtualPort = domxml.createElement('virtualport')
--
To view, visit http://gerrit.ovirt.org/15410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
