Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm_hooks/openstacknet/before_vm_start.py Line 1: #!/usr/bin/python Line 2: I know it's not part of the changeset but can you fix import statements (http://www.python.org/dev/peps/pep-0008/#imports) Line 3: import os Line 4: import sys Line 5: import hooking Line 6: import traceback -- To view, visit http://gerrit.ovirt.org/15410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
