Mark Wu has posted comments on this change.
Change subject: [WIP] hooks: Add OVS support to Quantum vNIC hook
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
just minor problems.
....................................................
File vdsm_hooks/quantumvnic/before_vm_start.py
Line 11:
Line 12: QVNIC_PREFIX = 'quantumvnic_'
Line 13:
Line 14: # The maximum device name length in linux.
Line 15: DEV_MAX_LENGTH = 14
I don't think it's maximum device name length in linux. it could just a magic
number in quantum.
Line 16:
Line 17: '''
Line 18: Openstack Quantum Hook
Line 19: ======================
Line 56:
Line 57: def addQuantumVnics(domxml, mac, portId):
Line 58: mac = mac.lower()
Line 59: for iface in domxml.getElementsByTagName('interface'):
Line 60: domMac = iface.getElementsByTagName('mac')[0]
Is renaming to ifaceMac better?
Line 61: domMacAddr = domMac.getAttribute('address').lower()
Line 62:
Line 63: if domMacAddr == mac:
Line 64: if config.get('quantumvnic_hook', 'plugin').lower() ==
"ovs":
--
To view, visit http://gerrit.ovirt.org/15410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
