Giuseppe Vallarelli has posted comments on this change.

Change subject: vm: add the live diskSizeExtend method
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Except for a minor comment in schema doc +1

....................................................
File vdsm_api/vdsmapi-schema.json
Line 5873: #
Line 5874: # Since: 4.12.0
Line 5875: ##
Line 5876: {'command': {'class': 'VM', 'name': 'diskSizeExtend'},
Line 5877:  'data': {'vmID': 'UUID', 'driveSpecs': 'DriveSpecVolume', 
'newSize': 'str'},
newSize str or int?
Line 5878:  'returns': 'str'}
Line 5879: 
Line 5880: ## Category: @Volume 
###########################################################
Line 5881: ##


-- 
To view, visit http://gerrit.ovirt.org/15614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to