Sergey Gotliv has posted comments on this change. Change subject: vm: add the live diskSizeExtend method ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Input parameters are switched when calling getVolumeSize API. .................................................... File vdsm/vm.py Line 3831: Line 3832: def _diskSizeExtendRaw(self, drive, newSizeBytes): Line 3833: volumeInfo = self.cif.irs.getVolumeSize( Line 3834: drive.poolID, drive.domainID, drive.imageID, drive.volumeID) Line 3835: getVolumeSize wants to receive domainID first, then poolId and.... Line 3836: sizeRoundedBytes = int(volumeInfo['apparentsize']) Line 3837: Line 3838: # For the RAW device we use the volumeInfo apparentsize rather Line 3839: # than the (possibly) wrong size provided in the request. -- To view, visit http://gerrit.ovirt.org/15614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
