Sergey Gotliv has posted comments on this change. Change subject: vm: add the live diskSizeExtend method ......................................................................
Patch Set 3: (3 inline comments) .................................................... File vdsm/storage/volume.py Line 714: # Going directly to the metadata parameter as we should skip the size Line 715: # validation in getSize. Line 716: if int(self.getMetaParam(SIZE)) < 1: Line 717: volInfo = qemuImg.info( Line 718: self.getVolumePath(), fmt2str(self.getFormat())) Can you reconsider the name of this method? Line 719: # qemu/qemu-img rounds down Line 720: self.setSize(volInfo['virtualsize'] / BLOCK_SIZE) Line 721: Line 722: def getType(self): .................................................... File vdsm/vm.py Line 3821: return errCode['updateDevice'] Line 3822: finally: Line 3823: # In all cases we want to try and fix the size in the metadata. Line 3824: # Same as above, this is what libvirt would do, see BZ#963881 Line 3825: sizeRounded = qemuImg.info(drive.path, "qcow2")['virtualsize'] Is this sizeRounded in bytes like in the method below? Line 3826: self.cif.irs.setVolumeSize( Line 3827: drive.domainID, drive.poolID, drive.imageID, drive.volumeID, Line 3828: sizeRounded) Line 3829: Line 3836: sizeRoundedBytes = int(volumeInfo['apparentsize']) Line 3837: Line 3838: # For the RAW device we use the volumeInfo apparentsize rather Line 3839: # than the (possibly) wrong size provided in the request. Line 3840: if sizeRoundedBytes != newSizeBytes: newSizeBytes must be greater or equal to the current size, right? Line 3841: self.log.info( Line 3842: "The requested extension size %s is different from " Line 3843: "the RAW device size %s", newSizeBytes, sizeRoundedBytes) Line 3844: -- To view, visit http://gerrit.ovirt.org/15614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
